Skip to content

Use 2-letter phone country code for analytics #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monfresh merged 1 commit into from
Aug 20, 2018
Merged

Use 2-letter phone country code for analytics #2442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/otp_delivery_selection_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def extra_analytics_attributes
{
otp_delivery_preference: otp_delivery_preference,
resend: resend,
country_code: parsed_phone.country_code,
country_code: parsed_phone.country,
area_code: parsed_phone.area_code,
context: context,
}
Expand Down
8 changes: 4 additions & 4 deletions spec/controllers/users/two_factor_authentication_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def index
otp_delivery_preference: 'sms',
resend: nil,
context: 'authentication',
country_code: '1',
country_code: 'US',
area_code: '202',
}

Expand Down Expand Up @@ -236,7 +236,7 @@ def index
otp_delivery_preference: 'voice',
resend: nil,
context: 'authentication',
country_code: '1',
country_code: 'US',
area_code: '202',
}

Expand Down Expand Up @@ -341,7 +341,7 @@ def index
otp_delivery_preference: 'sms',
resend: nil,
context: 'confirmation',
country_code: '1',
country_code: 'US',
area_code: '202',
}
twilio_error = "[HTTP 400] : error message\n\n"
Expand Down Expand Up @@ -379,7 +379,7 @@ def index
otp_delivery_preference: 'sms',
resend: nil,
context: 'confirmation',
country_code: '1',
country_code: 'US',
area_code: '202',
}
twilio_error_hash = {
Expand Down
2 changes: 1 addition & 1 deletion spec/forms/otp_delivery_selection_form_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
extra = {
otp_delivery_preference: 'sms',
resend: true,
country_code: '1',
country_code: 'US',
area_code: '202',
context: 'authentication',
}
Expand Down