Skip to content

LG43 remove equifax from application#2434

Merged
gregory-casamento merged 6 commits intomasterfrom
gcasa-LG43-remove-equifax
Aug 15, 2018
Merged

LG43 remove equifax from application#2434
gregory-casamento merged 6 commits intomasterfrom
gcasa-LG43-remove-equifax

Conversation

@gregory-casamento
Copy link
Contributor

@gregory-casamento gregory-casamento commented Aug 15, 2018

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

**Why**: Remove Equifax since we are no longer using it for IDV.

**How**: Remove all references to Equifax in all files.  Remove tests for equifax.
**why**: Remove all references.
/config/aws.yml
/keys/*.key.enc
!/keys/*.key.enc.example
/keys/equifax_rsa
Copy link
Contributor

@jmhooper jmhooper Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we leaves these in so the files people have locally won't start getting tracked?

@@ -1,46 +0,0 @@
#!/usr/bin/env ruby
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're gonna wanna remove the call to this script from the Circle config

/keys/*.key.enc
!/keys/*.key.enc.example
/keys/equifax_rsa
/keys/equifax_rsa.pub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to ignore any of these, not just the one. When I run git status on your branch, this is what I see:

image

Everyone who's been working on this since before we stoped generating those on make setup will see the same thing. We'll want to leave these in so they don't accidentally get checked in by one of us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

**Why**: Add references to equifax back into the .gitignore so that we can ignore those files on people's desktops that already have them.
@gregory-casamento gregory-casamento merged commit 916242e into master Aug 15, 2018
@gregory-casamento gregory-casamento deleted the gcasa-LG43-remove-equifax branch August 15, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants