Skip to content

Update gems with bummr#2420

Merged
monfresh merged 7 commits intomasterfrom
mb-update-gems
Aug 10, 2018
Merged

Update gems with bummr#2420
monfresh merged 7 commits intomasterfrom
mb-update-gems

Conversation

@monfresh
Copy link
Contributor

@monfresh monfresh commented Aug 10, 2018

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh merged commit 9a33525 into master Aug 10, 2018
@monfresh monfresh deleted the mb-update-gems branch August 10, 2018 15:43
@greysteil
Copy link

greysteil commented Aug 16, 2018

@monfresh - would you be up for using Dependabot to generate dependency update PRs automatically?

I noticed you're using Depfu on the codeforamerica/ohana-api repo - Dependabot is similar but we're a bit bigger and a bit more open source conscientious. The core of the product is open source here and I'm now a maintainer of Bundler having done a lot of work on it over the last 12 months - I try to ensure all the work on Dependabot benefits as many people as possible.

I'd particularly like you to use Dependabot on open source repos (for which it's free, of course!) because I can then use the results of CI runs on PRs that Dependabot creates to generate compatibility scores. At the moment we include those on all Dependabot PRs to help users know whether an update is safe to merge, but in future I want to expand their use to make it easy for maintainers to find any bugs in their releases / release candidates. Having open-source repos using Dependabot will be critical to that, because I'll actually be able to link the maintainer to the tests that fail as a result of their change.

What do you reckon? Thanks for your consideration. :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants