Conversation
|
@monfresh - would you be up for using Dependabot to generate dependency update PRs automatically? I noticed you're using Depfu on the I'd particularly like you to use Dependabot on open source repos (for which it's free, of course!) because I can then use the results of CI runs on PRs that Dependabot creates to generate compatibility scores. At the moment we include those on all Dependabot PRs to help users know whether an update is safe to merge, but in future I want to expand their use to make it easy for maintainers to find any bugs in their releases / release candidates. Having open-source repos using Dependabot will be critical to that, because I'll actually be able to link the maintainer to the tests that fail as a result of their change. What do you reckon? Thanks for your consideration. |
Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticatedas the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
Encryption
Routes
state or result in destructive behavior).
Session
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.