[LG-499] Rake task copies phone info to new table#2415
Conversation
There was a problem hiding this comment.
I'm open to other ideas for naming the task. It's a migration of data from one table to another, but this could also confuse folk looking for rails migrations.
There was a problem hiding this comment.
Assuming this is a one-time only task, I don't think the name matters a whole lot, but in the past, I've seen namespaces like adhoc used for one-off tasks.
What do you think about creating an issue to assign the running of this task to someone, and include the command to run?
Would there be a reason to keep this code around after the task is run? If not, another issue to remove the code from this PR after the task is run?
There was a problem hiding this comment.
Do we need confirmation_sent_at?
There was a problem hiding this comment.
What do you think about naming this CopyPhonesToPhoneConfigurations for more accuracy?
There was a problem hiding this comment.
What do you think about naming this call for consistency with our other service objects?
There was a problem hiding this comment.
Should we use create_phone_configuration! to catch any validation errors?
72b098c to
f9d11f4
Compare
**Why**: We want to make sure all phone configurations are present in the new table before we start reading data from the table. **How**: We use a rake task that processes users in batches to make sure a phone configuration row exists for the user.
f9d11f4 to
37242df
Compare
Why:
We want to make sure all phone configurations are present in
the new table before we start reading data from the table.
How:
We use a rake task that processes users in batches to make
sure a phone configuration row exists for the user.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticatedas the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
Encryption
Routes
state or result in destructive behavior).
Session
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.