Tear down code for phone profile verification

app/controllers/concerns/idv_session.rb

@@ -2,7 +2,7 @@ module IdvSession
   extend ActiveSupport::Concern
 
   def confirm_idv_session_started
-    return if current_user.decorate.needs_profile_usps_verification?
+    return if current_user.decorate.pending_profile_requires_verification?
     redirect_to idv_session_url if idv_session.params.blank?
   end
 

app/controllers/concerns/verify_profile_concern.rb

@@ -11,17 +11,8 @@ def account_or_verify_profile_url
 
   def account_or_verify_profile_route
     return 'account' if idv_context? || profile_context?
-    return 'account' unless current_user.decorate.pending_profile_requires_verification?
-    verify_profile_route
-  end
-
-  def verify_profile_route
-    decorated_user = current_user.decorate
-    if decorated_user.needs_profile_phone_verification?
-      flash[:notice] = t('account.index.verification.instructions')
-      return 'verify_profile_phone'
-    end
-    return 'verify_account' if decorated_user.needs_profile_usps_verification?
+    return 'account' unless profile_needs_verification?
+    'verify_account'
   end
 
   def profile_needs_verification?

app/controllers/idv/come_back_later_controller.rb

@@ -9,7 +9,7 @@ def show; end
     private
 
     def confirm_user_needs_usps_confirmation
-      redirect_to account_url unless current_user.decorate.needs_profile_usps_verification?
+      redirect_to account_url unless current_user.decorate.pending_profile_requires_verification?
     end
   end
 end

app/controllers/idv/usps_controller.rb

@@ -12,7 +12,7 @@ def create
       create_user_event(:usps_mail_sent, current_user)
       idv_session.address_verification_mechanism = :usps
 
-      if current_user.decorate.needs_profile_usps_verification?
+      if current_user.decorate.pending_profile_requires_verification?
         resend_letter
         redirect_to idv_come_back_later_url
       else

app/decorators/user_decorator.rb

@@ -74,14 +74,6 @@ def active_profile_newer_than_pending_profile?
     user.active_profile.activated_at >= pending_profile.created_at
   end
 
-  def needs_profile_phone_verification?
-    pending_profile_requires_verification? && pending_profile.phone_confirmed?
-  end
-
-  def needs_profile_usps_verification?
-    pending_profile_requires_verification? && !pending_profile.phone_confirmed?
-  end
-
   # This user's most recently activated profile that has also been deactivated
   # due to a password reset, or nil if there is no such profile
   def password_reset_profile

app/models/profile.rb

@@ -1,4 +1,6 @@
 class Profile < ApplicationRecord
+  self.ignored_columns = %w[phone_confirmed]
+
   belongs_to :user
   has_many :usps_confirmation_codes, dependent: :destroy
 

app/services/idv/profile_maker.rb

@@ -2,17 +2,15 @@ module Idv
   class ProfileMaker
     attr_reader :pii_attributes
 
-    def initialize(applicant:, user:, phone_confirmed:, user_password:)
+    def initialize(applicant:, user:, user_password:)
       self.pii_attributes = Pii::Attributes.new_from_hash(applicant)
       self.user = user
       self.user_password = user_password
-      self.phone_confirmed = phone_confirmed
     end
 
     def save_profile
       profile = Profile.new(
         deactivation_reason: :verification_pending,
-        phone_confirmed: phone_confirmed,
         user: user
       )
       profile.encrypt_pii(pii_attributes, user_password)

app/services/idv/session.rb

@@ -129,7 +129,6 @@ def applicant_params
     def build_profile_maker(user_password)
       Idv::ProfileMaker.new(
         applicant: applicant_params,
-        phone_confirmed: vendor_phone_confirmation || false,
         user: current_user,
         user_password: user_password
       )

app/view_models/account_show.rb

@@ -33,10 +33,8 @@ def password_reset_partial
   end
 
   def pending_profile_partial
-    if decorated_user.needs_profile_usps_verification?
+    if decorated_user.pending_profile_requires_verification?
       'accounts/pending_profile_usps'
-    elsif decorated_user.needs_profile_phone_verification?
-      'accounts/pending_profile_phone'
     else
       'shared/null'
     end

config/locales/account/en.yml

@@ -25,7 +25,6 @@ en:
         instructions: Your account requires a secret code to be verified.
         reactivate_button: Enter the code you received via US mail
         success: Your account has been verified.
-        with_phone_button: Verify with your phone
     items:
       delete_your_account: Delete your account
       personal_key: Personal key

config/locales/account/es.yml

@@ -25,7 +25,6 @@ es:
         instructions: Su cuenta requiere que un código secreto sea verificado.
         reactivate_button: Ingrese el código que recibió por correo postal.
         success: Su cuenta ha sido verificada.
-        with_phone_button: Verifique con su teléfono.
     items:
       delete_your_account: Eliminar su cuenta
       personal_key: Clave personal

config/locales/account/fr.yml

@@ -27,7 +27,6 @@ fr:
         instructions: Votre compte requiert la vérification d'un code secret.
         reactivate_button: Entrez le code que vous avez reçu par la poste
         success: Votre compte a été vérifié.
-        with_phone_button: Verifiez avec votre téléphone
     items:
       delete_your_account: Supprimer votre compte
       personal_key: Clé personnelle

config/routes.rb

@@ -115,8 +115,6 @@
         as: :verify_personal_key
     post '/account/reactivate/verify_personal_key' => 'users/verify_personal_key#create',
          as: :create_verify_personal_key
-    get '/account/verify_phone' => 'users/verify_profile_phone#index', as: :verify_profile_phone
-    post '/account/verify_phone' => 'users/verify_profile_phone#create'
     get '/account_recovery_setup' => 'account_recovery_setup#index'
 
     if FeatureManagement.piv_cac_enabled?

spec/controllers/idv/come_back_later_controller_spec.rb

@@ -2,12 +2,12 @@
 
 describe Idv::ComeBackLaterController do
   let(:user) { build_stubbed(:user, :signed_up) }
-  let(:needs_profile_usps_verification) { true }
+  let(:pending_profile_requires_verification) { true }
 
   before do
     user_decorator = instance_double(UserDecorator)
-    allow(user_decorator).to receive(:needs_profile_usps_verification?).
-      and_return(needs_profile_usps_verification)
+    allow(user_decorator).to receive(:pending_profile_requires_verification?).
+      and_return(pending_profile_requires_verification)
     allow(user).to receive(:decorate).and_return(user_decorator)
     allow(subject).to receive(:current_user).and_return(user)
   end
@@ -21,7 +21,7 @@
   end
 
   context 'user does not need USPS address verification' do
-    let(:needs_profile_usps_verification) { false }
+    let(:pending_profile_requires_verification) { false }
 
     it 'redirects to the account path' do
       get :show

spec/controllers/idv/confirmations_controller_spec.rb

@@ -15,7 +15,6 @@ def stub_idv_session
     profile_maker = Idv::ProfileMaker.new(
       applicant: applicant,
       user: user,
-      phone_confirmed: true,
       user_password: password
     )
     profile = profile_maker.save_profile

spec/controllers/idv/usps_controller_spec.rb

@@ -60,12 +60,12 @@
 
     context 'resending a letter' do
       let(:has_pending_profile) { true }
-      let(:pending_profile) { create(:profile, phone_confirmed: false) }
+      let(:pending_profile) { create(:profile) }
 
       before do
         stub_sign_in(user)
         stub_decorated_user_with_pending_profile(user)
-        allow(user.decorate).to receive(:needs_profile_usps_verification?).and_return(true)
+        allow(user.decorate).to receive(:pending_profile_requires_verification?).and_return(true)
       end
 
       it 'calls the UspsConfirmationMaker to send another letter and redirects' do

spec/controllers/users/sessions_controller_spec.rb

@@ -382,7 +382,6 @@
         profile = create(
           :profile,
           deactivation_reason: :verification_pending,
-          phone_confirmed: false,
           pii: { ssn: '6666', dob: '1920-01-01' }
         )
         user = profile.user

spec/controllers/users/verify_account_controller_spec.rb

@@ -17,8 +17,7 @@
       profile: pending_profile,
       otp_fingerprint: Pii::Fingerprinter.fingerprint(otp)
     )
-    allow(decorated_user).to receive(:needs_profile_phone_verification?).and_return(false)
-    allow(decorated_user).to receive(:needs_profile_usps_verification?).
+    allow(decorated_user).to receive(:pending_profile_requires_verification?).
       and_return(has_pending_profile)
   end
 

spec/decorators/user_decorator_spec.rb

@@ -204,84 +204,6 @@
     end
   end
 
-  describe '#needs_profile_phone_verification?' do
-    context 'pending profile does not require verification' do
-      it 'returns false' do
-        user = User.new
-        user_decorator = UserDecorator.new(user)
-        allow(user_decorator).to receive(:pending_profile_requires_verification?).
-          and_return(false)
-
-        expect(user_decorator.needs_profile_phone_verification?).to eq false
-      end
-    end
-
-    context 'pending profile requires verification and phone is confirmed' do
-      it 'returns true' do
-        user = User.new
-        user_decorator = UserDecorator.new(user)
-        allow(user_decorator).to receive(:pending_profile_requires_verification?).
-          and_return(true)
-        allow(user_decorator).to receive(:pending_profile).
-          and_return(Profile.new(phone_confirmed: true))
-
-        expect(user_decorator.needs_profile_phone_verification?).to eq true
-      end
-    end
-
-    context 'pending profile requires verification and phone is not confirmed' do
-      it 'returns false' do
-        user = User.new
-        user_decorator = UserDecorator.new(user)
-        allow(user_decorator).to receive(:pending_profile_requires_verification?).
-          and_return(true)
-        allow(user_decorator).to receive(:pending_profile).
-          and_return(Profile.new(phone_confirmed: false))
-
-        expect(user_decorator.needs_profile_phone_verification?).to eq false
-      end
-    end
-  end
-
-  describe '#needs_profile_usps_verification?' do
-    context 'pending profile does not require verification' do
-      it 'returns false' do
-        user = User.new
-        user_decorator = UserDecorator.new(user)
-        allow(user_decorator).to receive(:pending_profile_requires_verification?).
-          and_return(false)
-
-        expect(user_decorator.needs_profile_usps_verification?).to eq false
-      end
-    end
-
-    context 'pending profile requires verification and phone is not confirmed' do
-      it 'returns true' do
-        user = User.new
-        user_decorator = UserDecorator.new(user)
-        allow(user_decorator).to receive(:pending_profile_requires_verification?).
-          and_return(true)
-        allow(user_decorator).to receive(:pending_profile).
-          and_return(Profile.new(phone_confirmed: false))
-
-        expect(user_decorator.needs_profile_usps_verification?).to eq true
-      end
-    end
-
-    context 'pending profile requires verification and phone is confirmed' do
-      it 'returns false' do
-        user = User.new
-        user_decorator = UserDecorator.new(user)
-        allow(user_decorator).to receive(:pending_profile_requires_verification?).
-          and_return(true)
-        allow(user_decorator).to receive(:pending_profile).
-          and_return(Profile.new(phone_confirmed: true))
-
-        expect(user_decorator.needs_profile_usps_verification?).to eq false
-      end
-    end
-  end
-
   describe '#should_acknowledge_personal_key?' do
     context 'user has no personal key' do
       context 'service provider with loa1' do