Skip to content

LG-491 Don't truncate scrypt digest in pii encryption#2355

Merged
jmhooper merged 3 commits intomasterfrom
jmhooper-32-byte-pii-encryption
Jul 23, 2018
Merged

LG-491 Don't truncate scrypt digest in pii encryption#2355
jmhooper merged 3 commits intomasterfrom
jmhooper-32-byte-pii-encryption

Conversation

@jmhooper
Copy link
Contributor

Why: The original 2L-KMS implementation truncated the output from
the scrypt digest. We wanted to configure SCrypt to output 32 bytes, but
after checking, it was already configured to do that. The reason we had
to truncate, is because the output was hex encoded making it 64
characters long.

This commit hex decodes the digest and uses the 32 byte result to
encrypt the PII.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

**Why**: The original 2L-KMS implementation truncated the output from
the scrypt digest. We wanted to configure SCrypt to output 32 bytes, but
after checking, it was already configured to do that. The reason we had
to truncate, is because the output was hex encoded making it 64
characters long.

This commit hex decodes the digest and uses the 32 byte result to
encrypt the PII.
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants