LG-490 Verify password hashes without digesting salts#2354
Merged
Conversation
**Why**: Previously, we generated 20 char random strings for our password salts. To get those string to an appropriate length for an SCrypt salt, we took a SHA256 digest of the string. We plan to start using 32 random bytes for the salt so we can use them directly instead of hashing them. This commit adds the code to read the new digests and tests to verify the old digests can still be verified after the change to 32 random bytes is implemented. This commit will not have any impact when deployed, but allows instances generating 20 byte and 32 byte digests to serve traffic together so that we can make the change to 32 byte digests.
Contributor
Author
|
Having some issues w/ some test so I'm flipping to WIP |
Contributor
Author
|
Got it green. Ready for review. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Previously, we generated 20 char random strings for our
password salts. To get those string to an appropriate length for an
SCrypt salt, we took a SHA256 digest of the string.
We plan to start using 32 random bytes for the salt so we can use them
directly instead of hashing them. This commit adds the code to read the
new digests and tests to verify the old digests can still be verified
after the change to 32 random bytes is implemented.
This commit will not have any impact when deployed, but allows instances
generating 20 byte and 32 byte digests to serve traffic together so that
we can make the change to 32 byte digests.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
afect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.