Conversation
monfresh
reviewed
Jul 19, 2018
spec/features/users/sign_in_spec.rb
Outdated
Contributor
There was a problem hiding this comment.
can we also add a test for the error message?
stevegsa
force-pushed
the
fix-500-error-on-bad-personal-key
branch
from
e6818e0 to
0238d16
Compare
stevegsa
changed the title
stevegsa
changed the title
stevegsa
changed the title
stevegsa
force-pushed
the
fix-500-error-on-bad-personal-key
branch
from
e77e855 to
a265b31
Compare
monfresh
reviewed
Jul 19, 2018
| end | ||
| get '/login/two_factor/:otp_delivery_preference' => 'two_factor_authentication/otp_verification#show', | ||
| as: :login_two_factor | ||
| as: :login_two_factor, constraints: { otp_delivery_preference: /sms|voice/ } |
Contributor
There was a problem hiding this comment.
should we make the regex beginning of string, end of string to be safe?
Contributor
Author
There was a problem hiding this comment.
I know it's not needed and verified that xsmsx returns a 404. But I remember banging my head trying to understand why years ago. Is the beginning of string end of string implied when it uses constraints?
Contributor
Author
There was a problem hiding this comment.
It's obviously not doing regular regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.