Skip to content

Ignore the old password columns on the user model (#2329)#2330

Merged
jgsmith-usds merged 1 commit intostages/intfrom
stages/rc-2018-07-20
Jul 17, 2018
Merged

Ignore the old password columns on the user model (#2329)#2330
jgsmith-usds merged 1 commit intostages/intfrom
stages/rc-2018-07-20

Conversation

@jgsmith-usds
Copy link
Contributor

Why: The old deployed code does not realize the columns have been
dropped, so it breaks when it tries to load them into the model.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

**Why**: The old deployed code does not realize the columns have been
dropped, so it breaks when it tries to load them into the model.
@jgsmith-usds jgsmith-usds merged commit 0df0bc5 into stages/int Jul 17, 2018
@mitchellhenke mitchellhenke deleted the stages/rc-2018-07-20 branch December 28, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants