Skip to content

LG-464 Update attribute encryption rake task to log errors and continue#2322

Merged
stevegsa merged 1 commit intomasterfrom
stevegsa-rescue-attribute-encryption-errors-in-rake-task
Jul 16, 2018
Merged

LG-464 Update attribute encryption rake task to log errors and continue#2322
stevegsa merged 1 commit intomasterfrom
stevegsa-rescue-attribute-encryption-errors-in-rake-task

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jul 15, 2018

Why: The script halts if there is an encryption exception with a single account

How: Put an EncryptionError rescue block in the rake task

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rescue from Encryption::EncryptionError and not all of StandardError?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally had StandardError but switched it out at the last minute thinking we might have an even bigger problem and should probably halt if it's not an encryption error. I also entertained putting in a task that simply does a dry run first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have a problem switching it back to StandardError.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔, yeah I think that's what I'd do. We see plenty of errors related to encryption that are not strictly encryption errors.

Why: The script halts if there is an encryption exception with a single account

How: Put an EncryptionError rescue block in the rake task
@stevegsa stevegsa force-pushed the stevegsa-rescue-attribute-encryption-errors-in-rake-task branch from d560cab to 2869e2b Compare July 16, 2018 14:57
@stevegsa stevegsa merged commit 6953e60 into master Jul 16, 2018
rotator.rotate
progress&.increment
rescue StandardError => err # Don't use user.email in output...
Kernel.puts "Error with user id:#{user.id} #{err.message} #{err.backtrace}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ID and not UUID? Does it matter here?

@amathews-fs amathews-fs deleted the stevegsa-rescue-attribute-encryption-errors-in-rake-task branch January 7, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants