Conversation
Contributor
Author
|
You can see this in action in QA: https://idp.qa.identitysandbox.gov |
Contributor
Author
|
Before merging, I will need to create a distribution for dev, and then before deploying to the lower envs and production, we will need to create Cloudfront distributions for them as well. |
monfresh
commented
Jul 14, 2018
config/environments/production.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
I don't think this does anything. I didn't see any requests to our servers or Cloudfront when opening up email in QA.
stevegsa
reviewed
Jul 14, 2018
config/environments/production.rb
Outdated
Contributor
There was a problem hiding this comment.
Do we want to have a default in case this isn't set? Ah looks like nil is fine. Disregard.
Contributor
Author
There was a problem hiding this comment.
Good point. We should either make it required, or fall back to serving assets from nginx.
**Why**: Moving assets to be served from Cloudfront as opposed to nginx will reduce the load on our servers, and will make the site faster for users across the globe. On the Rails app side, this is a trivial change. The tricky part is setting up the Cloudfront distribution and making sure to select `Whitelist` from the `Cache Based on Selected Request Headers` dropdown, and add the `Origin` header to the `Whitelist Headers`. Then, add the following headers to the nginx config for fonts: `Access-Control-Allow-Origin` set to the current server domain name, including the protocol, such as `https://secure.login.gov`, and `Access-Control-Allow-Methods` set to `GET`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Moving assets to be served from Cloudfront as opposed to nginx
will reduce the load on our servers, and will make the site faster for
users across the globe.
On the Rails app side, this is a trivial change. The tricky part is
setting up the Cloudfront distribution and making sure to select
Whitelistfrom theCache Based on Selected Request Headersdropdown,and add the
Originheader to theWhitelist Headers. Then, add thefollowing headers to the nginx config for fonts:
Access-Control-Allow-Originset to the current server domain name,including the protocol, such as
https://secure.login.gov, andAccess-Control-Allow-Methodsset toGET.Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.