LG-462 Add tsp.move.mil service provider

[stevegsa]

Why: tsp.move.mil has complete integration testing and is ready to be promoted to production.

How: Update service_providers.yml

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

• For DB changes, check for missing indexes, check to see if the changes
  affect other apps (such as the dashboard), make sure the DB columns in the
  various environments are properly populated, coordinate with devops, plan
  migrations in separate steps.

• For route changes, make sure GET requests don't change state or result in
  destructive behavior. GET requests should only result in information being
  read, not written.

• For encryption changes, make sure it is compatible with data that was
  encrypted with the old code.

• For secrets changes, make sure to update the S3 secrets bucket with the
  new configs in all environments.

• Do not disable Rubocop or Reek offenses unless you are absolutely sure
  they are false positives. If you're not sure how to fix the offense, please
  ask a teammate.

• When reading data, write tests for nil values, empty strings,
  and invalid formats.

• When calling redirect_to in a controller, use _url, not _path.

• When adding user data to the session, use the user_session helper
  instead of the session helper so the data does not persist beyond the user's
  session.

• When adding a new controller that requires the user to be fully
  authenticated, make sure to add before_action :confirm_two_factor_authenticated.

[chrisgilmerproj]

This looks great, thanks for doing this for us!

[chrisgilmerproj]

The other move.mil sites have the attribute_bundle as:

• x509_subject
• x509_presented

Should we change from email to use these? I'm referring to this code:

https://github.com/18F/identity-idp/blob/master/config/service_providers.yml#L617-L651

[jgsmith-usds]

You need the x509_subject and maybe x509_presented if you need the subject of the piv/cac cert. Otherwise, if email is sufficient, you can get by with email. Additionally, you will need to request the x509 scope when you make the request to the oidc endpoints.

[chrisgilmerproj]

Thanks @jgsmith-usds ! That answers it for me. For now email is sufficient.