Skip to content

LG-289 Drop old encrypted password columns#2311

Merged
jmhooper merged 1 commit intomasterfrom
jmhooper-drop-encrypted-password-columns
Jul 13, 2018
Merged

LG-289 Drop old encrypted password columns#2311
jmhooper merged 1 commit intomasterfrom
jmhooper-drop-encrypted-password-columns

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Jul 9, 2018

Why: We are no longer using these columns in favor of
encrypted_password_digest

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

**Why**: We are no longer using these columns in favor of
`encrypted_password_digest`
@monfresh
Copy link
Contributor

Does this require doing anything before deploying next week? Are we sure no users still depend on these columns?

Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper
Copy link
Contributor Author

I've backfilled everything. The only problem I anticipate is potentially the issue with columns that have a null value where we expect an empty string. That should have been fixed by Steve's patch, but I'll go through and double check and backfill those just to be sure.

@jmhooper jmhooper merged commit 4322e8c into master Jul 13, 2018
@jmhooper jmhooper deleted the jmhooper-drop-encrypted-password-columns branch February 15, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants