Skip to content

LG-451 Remove duplicate SMS sent with account reset delayed notification#2309

Merged
stevegsa merged 1 commit intomasterfrom
remove-duplicate-sms-for-account-reset
Jul 6, 2018
Merged

LG-451 Remove duplicate SMS sent with account reset delayed notification#2309
stevegsa merged 1 commit intomasterfrom
remove-duplicate-sms-for-account-reset

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jul 6, 2018

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

Copy link
Contributor

@jgsmith-usds jgsmith-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Did we want to send no SMS at all? Or change the message so the second text isn't just repeating the first?

@stevegsa
Copy link
Contributor Author

stevegsa commented Jul 6, 2018

There was only supposed to be one SMS message when they requested an account reset to give them an opportunity to cancel.

@stevegsa stevegsa merged commit 6861082 into master Jul 6, 2018
SmsAccountResetNotifierJob.perform_now(
phone: user.phone,
cancel_token: arr.request_token
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write a spec for this please?

@amathews-fs amathews-fs deleted the remove-duplicate-sms-for-account-reset branch January 7, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants