Skip to content

LG-393 Redesign IDV verification OTP delivery method template#2302

Merged
mryenq merged 1 commit intomasterfrom
mryenq-redesign-otp-delivery
Jul 6, 2018
Merged

LG-393 Redesign IDV verification OTP delivery method template#2302
mryenq merged 1 commit intomasterfrom
mryenq-redesign-otp-delivery

Conversation

@mryenq
Copy link
Contributor

@mryenq mryenq commented Jul 5, 2018

Why: To simplify the page, per a design review.

How: Modify the text and layout of the screen,
add new content and link.

Since the result is similar to the existing OTP screen in the
main 2FA flow, the same messaging (labels/translations) from
that page is now shared.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

**Why**: To simplify the page, per a design review.

**How**: Modify the text and layout of the screen,
add new content and link.

Since the result is similar to the existing OTP screen in the
main 2FA flow, the same messaging (labels/translations) from
that page is now shared.
@jmhooper
Copy link
Contributor

jmhooper commented Jul 6, 2018

Mind posting a screenshot here?

@mryenq
Copy link
Contributor Author

mryenq commented Jul 6, 2018

@jmhooper:

idv_otp_redesign_20180706

Copy link
Contributor

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@mryenq mryenq merged commit e413810 into master Jul 6, 2018
@mryenq mryenq deleted the mryenq-redesign-otp-delivery branch July 6, 2018 16:02
@stevegsa
Copy link
Contributor

stevegsa commented Jul 6, 2018

Did we do away with obscuring part of the phone number?

screen shot 2018-07-06 at 12 03 29 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants