Make Programmable SMS countries configurable#2298
Merged
Conversation
**Why**: Twilio's Verify service cannot send SMS to Canada out of the box. It requires purchasing a separate option. **How**: Make the list of countries that should use Programmable SMS configurable, and add Canada to that list.
jmhooper
reviewed
Jul 5, 2018
| piv_cac_agencies: '["DOD"]' | ||
| piv_cac_enabled: 'false' | ||
| pkcs11_lib: '/opt/cloudhsm/lib/libcloudhsm_pkcs11.so' | ||
| programmable_sms_countries: 'US,CA' |
Contributor
There was a problem hiding this comment.
One suggestion I'd have would be a JSON encoded string here, since we seem the be doing that with these kind of collection elsewhere (see piv_cac_agencies above).
jmhooper
approved these changes
Jul 5, 2018
Contributor
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
One comment, but I don't feel super strongly about it. This lgtm.
jmhooper
reviewed
Jul 5, 2018
| ) | ||
| ) | ||
|
|
||
| SmsOtpSenderJob.perform_now( |
Contributor
There was a problem hiding this comment.
Another thing to think about is whether this fits better in a before block
Contributor
There was a problem hiding this comment.
Wait, never mind, I totally read this wrong. Ignore
Contributor
Author
|
Closing and reopening as a new RC branch based off the current one because the code on master is not compatible with RC 61. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Twilio's Verify service cannot send SMS to Canada out of the
box. It requires purchasing a separate option.
How: Make the list of countries that should use Programmable SMS
configurable, and add Canada to that list.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.