-
Notifications
You must be signed in to change notification settings - Fork 166
Remove TODOs from codebase #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,8 +75,6 @@ def decode_request(uri, token) | |
| end | ||
|
|
||
| def authenticate(token) | ||
| # TODO: make this secret required once we have everything deployed and configured | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See issue LG-441 |
||
| # The piv/cac service side is pending, so this is not critical yet. | ||
| secret = Figaro.env.piv_cac_verify_token_secret | ||
| return '' if secret.blank? | ||
| nonce = SecureRandom.hex(10) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -201,10 +201,6 @@ development: | |
| # These values serve as defaults for all production-like environments, which | ||
| # includes *.identitysandbox.gov and *.login.gov. | ||
| # | ||
| # TODO: remove empty/fake values from this block, which create the misleading | ||
| # impression that these values aren't used. In fact they will be used unless | ||
| # they are overriden by keys with the same name in the application.yml in the | ||
| # app secrets bucket. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See issue LG-440 |
||
| production: | ||
| aamva_cert_enabled: 'true' | ||
| aamva_public_key: # Base64 encoded public key for AAMVA | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -183,10 +183,6 @@ | |
| end | ||
| end | ||
| end | ||
|
|
||
| # context 'when choosing to sign in' do | ||
| # TODO: duplicate scenarios from Create Account here | ||
| # end | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already have a scenario for signing in at the bottom of this file. Furthermore, it doesn't look like anyone is using this feature anymore because it hasn't been updated in a while and no one has complained about it being broken. |
||
| end | ||
|
|
||
| context 'when LOA1' do | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not user facing, where user = site visitor. I'm not sure it's worth localizing them. We don't localize other IdP-to-SP API error messages.