Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codeclimate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ plugins:
- '.codeclimate.yml'
config:
strings:
# Removed TODO from this list, as we want to allow TODOs in the codebase
- TODO
- FIXME
- HACK
- BUG
Expand Down
1 change: 0 additions & 1 deletion app/controllers/concerns/user_session_context.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ def context
user_session[:context] || DEFAULT_CONTEXT
end

# TODO: Figure out better names for this and the method below
def initial_authentication_context?
context == DEFAULT_CONTEXT
end
Expand Down
1 change: 0 additions & 1 deletion app/forms/openid_connect_token_form.rb
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def validate_client_assertion
sub: client_id, verify_sub: true)
validate_aud_claim(payload)
rescue JWT::DecodeError => err
# TODO: i18n these JWT gem error messages
Copy link
Copy Markdown
Contributor Author

@monfresh monfresh Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not user facing, where user = site visitor. I'm not sure it's worth localizing them. We don't localize other IdP-to-SP API error messages.

errors.add(:client_assertion, err.message)
end

Expand Down
1 change: 0 additions & 1 deletion app/javascript/packs/personal-key-page-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ const personalKey = scrapePersonalKey();

// The following methods are strictly fallbacks for IE < 11. There is limited
// support for HTML5 validation attributes in those browsers
// TODO: Potentially investigate readding client-side JS errors in a robust way
function setInvalidHTML() {
if (isInvalidForm) return;

Expand Down
2 changes: 0 additions & 2 deletions app/services/piv_cac_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ def decode_request(uri, token)
end

def authenticate(token)
# TODO: make this secret required once we have everything deployed and configured
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See issue LG-441

# The piv/cac service side is pending, so this is not critical yet.
secret = Figaro.env.piv_cac_verify_token_secret
return '' if secret.blank?
nonce = SecureRandom.hex(10)
Expand Down
4 changes: 0 additions & 4 deletions config/application.yml.example
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,6 @@ development:
# These values serve as defaults for all production-like environments, which
# includes *.identitysandbox.gov and *.login.gov.
#
# TODO: remove empty/fake values from this block, which create the misleading
# impression that these values aren't used. In fact they will be used unless
# they are overriden by keys with the same name in the application.yml in the
# app secrets bucket.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See issue LG-440

production:
aamva_cert_enabled: 'true'
aamva_public_key: # Base64 encoded public key for AAMVA
Expand Down
4 changes: 0 additions & 4 deletions spec/features/flows/sp_authentication_flows_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,6 @@
end
end
end

# context 'when choosing to sign in' do
# TODO: duplicate scenarios from Create Account here
# end
Copy link
Copy Markdown
Contributor Author

@monfresh monfresh Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a scenario for signing in at the bottom of this file. Furthermore, it doesn't look like anyone is using this feature anymore because it hasn't been updated in a while and no one has complained about it being broken.

end

context 'when LOA1' do
Expand Down
1 change: 0 additions & 1 deletion spec/features/two_factor_authentication/sign_in_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,6 @@ def submit_prefilled_otp_code
end
end

# TODO: readd profile redirect, modal tests
describe 'signing in when user does not already have personal key' do
# For example, when migrating users from another DB
it 'displays personal key and redirects to profile' do
Expand Down
1 change: 0 additions & 1 deletion spec/lib/worker_health_checker_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
end

def create_sidekiq_queues(*queues)
# TODO: find an API to use rather than manually mess with redis?
Sidekiq.redis do |redis|
queues.each do |queue|
redis.sadd('queues', queue)
Expand Down