Skip to content

LG-365 Make CTA full width on mobile for certain screens#2291

Merged
mryenq merged 1 commit intomasterfrom
mryenq-format-buttons-full-width-mobile
Jul 5, 2018
Merged

LG-365 Make CTA full width on mobile for certain screens#2291
mryenq merged 1 commit intomasterfrom
mryenq-format-buttons-full-width-mobile

Conversation

@mryenq
Copy link
Contributor

@mryenq mryenq commented Jul 3, 2018

Why: Example IDV phone verification step page isn't
rendering button at full-width at smaller screen sizes.
Most of our views are similar.

How: Adjust button (and input, in the case of our
phone input control) styling on these pages to be
responsive at full-width and smaller screen sizes (our
main break point presently occurs at 40em/640px).

Tested in Firefox and Chrome were the following flows:

  • sign-up
  • sign-in
  • password reset
  • IDV process
  • etc.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

**Why**: Example IDV phone verification step page isn't
rendering button at full-width at smaller screen sizes.
Most of our views are similar.

**How**: Adjust button (and input, in the case of our
phone input control) styling on these pages to be
responsive at full-width and smaller screen sizes (our
main break point presently occurs at 40em/640px).

Tested in Firefox and Chrome were the following flows:

- sign-up
- sign-in
- password reset
- IDV process
- etc.
Copy link
Contributor

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mryenq mryenq merged commit 3cde23e into master Jul 5, 2018
@mryenq mryenq deleted the mryenq-format-buttons-full-width-mobile branch July 5, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants