Skip to content

Use Hash to map Twilio errors to user-facing text#2275

Merged
monfresh merged 1 commit intomasterfrom
mb-twilio-errors
Jun 28, 2018
Merged

Use Hash to map Twilio errors to user-facing text#2275
monfresh merged 1 commit intomasterfrom
mb-twilio-errors

Conversation

@monfresh
Copy link
Contributor

Why: To remove unnecessary conditionals in the controller and to
have one place to define the text that goes with each error. This will
make it easier to implement Twilio Verify.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

**Why**: To remove unnecessary conditionals in the controller and to
have one place to define the text that goes with each error. This will
make it easier to implement Twilio Verify.
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh merged commit c5152d2 into master Jun 28, 2018
@monfresh monfresh deleted the mb-twilio-errors branch June 28, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants