Skip to content

Update USPS upload logic to use GPO instead of Equifax#2267

Merged
davemcorwin merged 4 commits intomasterfrom
LG-401-use-gpo
Jun 25, 2018
Merged

Update USPS upload logic to use GPO instead of Equifax#2267
davemcorwin merged 4 commits intomasterfrom
LG-401-use-gpo

Conversation

@davemcorwin
Copy link
Contributor

@davemcorwin davemcorwin commented Jun 23, 2018

  • Switches usps upload to use GPO instead of equifax
  • Removes encryption
  • Removes unused code
  • Refactoring

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments. see LG-407

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

@davemcorwin
Copy link
Contributor Author

@jmhooper Just realized I may have torn out more than I should, does the PII thats temporarily saved in the db need to be encrypted?

def perform
entry = UspsConfirmationEntry.new_from_hash(attributes)
UspsConfirmation.create!(entry: entry.encrypted)
UspsConfirmation.create!(entry: attributes.to_json)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want this to be encrypted, right? This will result in raw PII in our database otherwise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw your comment, above. Yeah, the PII in temporarily saved in the DB needs to be encrypted.

@davemcorwin
Copy link
Contributor Author

@jmhooper ok encryption re-engage! PTAL

Copy link
Contributor

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@davemcorwin davemcorwin merged commit 263df8d into master Jun 25, 2018
@davemcorwin davemcorwin deleted the LG-401-use-gpo branch June 25, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants