Skip to content

[LG-324] Add piv/cac subject to attributes for move.mil#2263

Merged
jgsmith-usds merged 1 commit intomasterfrom
add-x509-subject-to-move-dot-mil-sp
Jun 26, 2018
Merged

[LG-324] Add piv/cac subject to attributes for move.mil#2263
jgsmith-usds merged 1 commit intomasterfrom
add-x509-subject-to-move-dot-mil-sp

Conversation

@jgsmith-usds
Copy link
Contributor

@jgsmith-usds jgsmith-usds commented Jun 20, 2018

Why:
Move.mil needs to know the subject of the piv/cac so
they can link the user's account to resources in DoD.

How:
Add the subject of the cert to the attribute bundle
provided via OIDC.

N.B.: Looks like I needed to tweak a few other things for the piv/cac subject to show up in a test OIDC client. Added them to this PR since they're all aimed at the same goal.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

@jgsmith-usds jgsmith-usds requested a review from stevegsa June 20, 2018 20:49
@jgsmith-usds jgsmith-usds changed the title Add piv/cac subject to attributes for move.mil [LG-324] Add piv/cac subject to attributes for move.mil Jun 22, 2018
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Has the PIV/CAC service been updated to return the subject key?

@jgsmith-usds
Copy link
Contributor Author

It was already using subject 🤦‍♂️ , so this is fixing the IdP to match (https://github.com/18F/identity-pki/blob/master/app/models/certificate.rb#L134).

**Why**:
Move.mil needs to know the subject of the piv/cac so
they can link the user's account to resources in DoD.

**How**:
Add the subject of the cert to the attribute bundle
provided via OIDC.
@jgsmith-usds jgsmith-usds force-pushed the add-x509-subject-to-move-dot-mil-sp branch from f663324 to 0896aa0 Compare June 26, 2018 13:22
@monfresh monfresh closed this Jun 26, 2018
@monfresh monfresh reopened this Jun 26, 2018
@jgsmith-usds jgsmith-usds merged commit c8aee5f into master Jun 26, 2018
@jgsmith-usds jgsmith-usds deleted the add-x509-subject-to-move-dot-mil-sp branch June 26, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants