LG-362 LOA3 fail states

.codeclimate.yml

@@ -90,6 +90,7 @@ plugins:
 exclude_patterns:
   - 'db/schema.rb'
   - 'node_modules/'
+  - 'lib/proofer_mocks/'
   - 'lib/rspec/formatters/user_flow_formatter.rb'
   - 'lib/tasks/create_test_accounts.rb'
   - 'lib/user_flow_exporter.rb'

app/assets/javascripts/i18n-strings.js.erb

@@ -12,7 +12,7 @@ window.LoginGov = window.LoginGov || {};
   'idv.errors.pattern_mismatch.personal_key',
   'idv.errors.pattern_mismatch.ssn',
   'idv.errors.pattern_mismatch.zipcode',
-  'idv.modal.button.warning',
+  'idv.failure.button.warning',
   'instructions.password.strength.i',
   'instructions.password.strength.ii',
   'instructions.password.strength.iii',

app/controllers/concerns/idv_failure_concern.rb

@@ -1,37 +1,54 @@
 module IdvFailureConcern
   extend ActiveSupport::Concern
 
-  # rubocop:disable Metrics/MethodLength
-  def render_failure
-    if step_attempts_exceeded?
-      @view_model = view_model(error: 'fail')
-      flash_message(type: :error)
-    elsif step.vendor_validator_job_failed?
-      @view_model = view_model(error: 'jobfail')
-      flash_message(type: :warning)
-    elsif form_valid_but_vendor_validation_failed?
-      @view_model = view_model(error: 'warning', timed_out: step.vendor_validation_timed_out?)
-      flash_message(type: :warning)
-    else
-      @view_model = view_model
-    end
-  end
-  # rubocop:enable Metrics/MethodLength
-
-  def form_valid_but_vendor_validation_failed?
-    idv_form.valid? && !step.vendor_validation_passed?
-  end
-
-  def flash_message(type:)
-    flash.now[type.to_sym] = @view_model.flash_message
-  end
-
-  def view_model(error: nil, timed_out: nil)
-    view_model_class.new(
-      error: error,
+  def idv_step_failure_reason
+    return :fail if fail?
+    return :jobfail if jobfail?
+    return :timeout if timeout?
+    return :warning if warning?
+  end
+
+  def render_idv_step_failure(step, reason)
+    return render_failure('shared/_failure', failure_presenter(step)) if reason == :fail
+    render_failure('idv/shared/verification_failure', warning_presenter(step, reason))
+  end
+
+  def render_failure(template, presenter)
+    render_full_width(template, locals: { presenter: presenter })
+  end
+
+  private
+
+  def fail?
+    idv_attempter.exceeded? || step_attempts_exceeded?
+  end
+
+  def jobfail?
+    step.vendor_validator_job_failed?
+  end
+
+  def timeout?
+    !step.vendor_validation_passed? && step.vendor_validation_timed_out?
+  end
+
+  def warning?
+    !step.vendor_validation_passed? && !step.vendor_validation_timed_out?
+  end
+
+  def failure_presenter(step)
+    Idv::MaxAttemptsFailurePresenter.new(
+      decorated_session: decorated_session,
+      step_name: step,
+      view_context: view_context
+    )
+  end
+
+  def warning_presenter(step, reason)
+    Idv::WarningPresenter.new(
+      reason: reason,
       remaining_attempts: remaining_step_attempts,
-      idv_form: idv_form,
-      timed_out: timed_out
+      step_name: step,
+      view_context: view_context
     )
   end
 end

app/controllers/concerns/idv_session.rb

@@ -8,9 +8,8 @@ def confirm_idv_session_started
 
   def confirm_idv_attempts_allowed
     if idv_attempter.exceeded?
-      flash[:error] = t('idv.errors.hardfail')
       analytics.track_event(Analytics::IDV_MAX_ATTEMPTS_EXCEEDED, request_path: request.path)
-      redirect_to idv_fail_url
+      redirect_to failure_url(:fail)
     elsif idv_attempter.reset_attempts?
       idv_attempter.reset
     end

app/controllers/concerns/idv_step_concern.rb

@@ -28,7 +28,6 @@ def confirm_step_allowed
   end
 
   def redirect_to_fail_url
-    flash[:max_attempts_exceeded] = true
-    redirect_to idv_fail_url
+    redirect_to failure_url(:fail)
   end
 end

app/controllers/idv/jurisdiction_controller.rb

@@ -5,7 +5,7 @@ class JurisdictionController < ApplicationController
     before_action :confirm_two_factor_authenticated
     before_action :confirm_idv_attempts_allowed
     before_action :confirm_idv_needed
-    before_action :set_jurisdiction_form, only: %i[new create]
+    before_action :set_jurisdiction_form, except: [:failure]
 
     def new
       analytics.track_event(Analytics::IDV_JURISDICTION_VISIT)
@@ -22,12 +22,12 @@ def create
         # The only invalid result here is due to an unsupported jurisdiction
         # and if it is missing from the params, it will be stopped by
         # `strong_params`.
-        redirect_to idv_jurisdiction_fail_url(:unsupported_jurisdiction)
+        redirect_to failure_url(:unsupported_jurisdiction)
       end
     end
 
-    def show
-      presenter = JurisdictionFailurePresenter.new(
+    def failure
+      presenter = Idv::JurisdictionFailurePresenter.new(
         reason: params[:reason],
         jurisdiction: user_session[:idv_jurisdiction],
         view_context: view_context
@@ -44,5 +44,9 @@ def jurisdiction_params
     def set_jurisdiction_form
       @jurisdiction_form ||= Idv::JurisdictionForm.new
     end
+
+    def failure_url(reason)
+      idv_jurisdiction_failure_url(reason)
+    end
   end
 end

app/controllers/idv/phone_controller.rb

@@ -3,12 +3,14 @@ class PhoneController < ApplicationController
     include IdvStepConcern
     include IdvFailureConcern
 
+    attr_reader :idv_form
+
     before_action :confirm_step_needed
-    before_action :confirm_step_allowed
+    before_action :confirm_step_allowed, except: [:failure]
     before_action :refresh_if_not_ready, only: [:show]
+    before_action :set_idv_form, except: [:failure]
 
     def new
-      @view_model = view_model
       analytics.track_event(Analytics::IDV_PHONE_RECORD_VISIT)
     end
 
@@ -20,7 +22,6 @@ def create
         Idv::Job.submit(idv_session, [:address])
         redirect_to idv_phone_result_url
       else
-        @view_model = view_model
         render :new
       end
     end
@@ -30,12 +31,12 @@ def show
       analytics.track_event(Analytics::IDV_PHONE_CONFIRMATION_VENDOR, result.to_h)
       increment_step_attempts
 
-      if result.success?
-        redirect_to_next_step
-      else
-        render_failure
-        render :new
-      end
+      redirect_to_next_step and return if result.success?
+      redirect_to idv_phone_failure_url(idv_step_failure_reason)
+    end
+
+    def failure
+      render_idv_step_failure(:phone, params[:reason].to_sym)
     end
 
     private
@@ -64,10 +65,6 @@ def step
       )
     end
 
-    def view_model_class
-      Idv::PhoneNew
-    end
-
     def step_params
       params.require(:idv_phone_form).permit(:phone)
     end
@@ -76,8 +73,12 @@ def confirm_step_needed
       redirect_to_next_step if idv_session.user_phone_confirmation == true
     end
 
-    def idv_form
-      @_idv_form ||= Idv::PhoneForm.new(idv_session.params, current_user)
+    def set_idv_form
+      @idv_form ||= Idv::PhoneForm.new(idv_session.params, current_user)
+    end
+
+    def failure_url(reason)
+      idv_phone_failure_url(reason)
     end
   end
 end

app/controllers/idv/sessions_controller.rb

@@ -4,8 +4,10 @@ class SessionsController < ApplicationController
     include IdvFailureConcern
     include PersonalKeyConcern
 
+    attr_reader :idv_form
+
     before_action :confirm_two_factor_authenticated, except: [:destroy]
-    before_action :confirm_idv_attempts_allowed, except: %i[destroy success]
+    before_action :confirm_idv_attempts_allowed, except: %i[destroy success failure]
     before_action :confirm_idv_needed
     before_action :confirm_step_needed, except: %i[destroy success]
     before_action :initialize_idv_session, only: [:create]
@@ -15,32 +17,36 @@ class SessionsController < ApplicationController
 
     def new
       user_session[:context] = 'idv'
-      @view_model = view_model
-      @view_model.selected_state = user_session[:idv_jurisdiction]
+      set_idv_form
+      @selected_state = user_session[:idv_jurisdiction]
       analytics.track_event(Analytics::IDV_BASIC_INFO_VISIT)
     end
 
     def create
+      set_idv_form
       result = idv_form.submit(profile_params)
       analytics.track_event(Analytics::IDV_BASIC_INFO_SUBMITTED_FORM, result.to_h)
 
       if result.success?
         Idv::Job.submit(idv_session, %i[resolution state_id])
         redirect_to idv_session_result_url
       else
-        process_failure
+        process_form_failure
       end
     end
 
     def show
       result = step.submit
       analytics.track_event(Analytics::IDV_BASIC_INFO_SUBMITTED_VENDOR, result.to_h)
 
-      if result.success?
-        process_success
-      else
-        process_failure
-      end
+      redirect_to idv_session_success_url and return if result.success?
+      redirect_to idv_session_failure_url(idv_step_failure_reason)
+    end
+
+    def failure
+      reason = params[:reason].to_sym
+      render_dupe_ssn_failure and return if reason == :dupe_ssn
+      render_idv_step_failure(:sessions, reason)
     end
 
     def success; end
@@ -71,31 +77,29 @@ def handle_idv_redirect
       redirect_to manage_personal_key_url
     end
 
-    def process_success
-      redirect_to idv_session_success_url
+    def process_form_failure
+      redirect_to idv_session_failure_url(:dupe_ssn) and return if idv_form.duplicate_ssn?
+      if (sp_name = decorated_session.sp_name) && idv_form.unsupported_jurisdiction?
+        idv_form.add_sp_unsupported_jurisdiction_error(sp_name)
+      end
+      render :new
     end
 
-    def process_failure
-      if idv_form.duplicate_ssn?
-        flash[:error] = t('idv.errors.duplicate_ssn')
-        redirect_to idv_session_dupe_url
-      else
-        render_failure
-        @view_model.unsupported_jurisdiction_error(decorated_session.sp_name)
-        render :new
-      end
+    def render_dupe_ssn_failure
+      presenter = Idv::SsnFailurePresenter.new(view_context: view_context)
+      render_failure('shared/_failure', presenter)
     end
 
-    def view_model_class
-      Idv::SessionsNew
+    def step_name
+      :sessions
     end
 
     def remaining_step_attempts
       Idv::Attempter.idv_max_attempts - current_user.idv_attempts
     end
 
-    def idv_form
-      @_idv_form ||= Idv::ProfileForm.new((idv_session.params || {}), current_user)
+    def set_idv_form
+      @idv_form ||= Idv::ProfileForm.new((idv_session.params || {}), current_user)
     end
 
     def initialize_idv_session
@@ -107,5 +111,9 @@ def initialize_idv_session
     def profile_params
       params.require(:profile).permit(Idv::ProfileForm::PROFILE_ATTRIBUTES)
     end
+
+    def failure_url(reason)
+      idv_session_failure_url(reason)
+    end
   end
 end

app/controllers/idv_controller.rb

@@ -26,7 +26,11 @@ def activated
   def cancel; end
 
   def fail
-    redirect_to idv_url unless ok_to_fail?
+    redirect_to idv_url and return unless idv_attempter.exceeded?
+    presenter = Idv::IdvFailurePresenter.new(
+      view_context: view_context
+    )
+    render_full_width('shared/_failure', locals: { presenter: presenter })
   end
 
   private
@@ -40,8 +44,4 @@ def profile_needs_reactivation?
   def active_profile?
     current_user.active_profile.present?
   end
-
-  def ok_to_fail?
-    idv_attempter.exceeded? || flash[:max_attempts_exceeded]
-  end
 end

app/decorators/service_provider_session_decorator.rb

@@ -78,10 +78,6 @@ def verification_method_choice
     I18n.t('idv.messages.select_verification_with_sp', sp_name: sp_name)
   end
 
-  def idv_hardfail4_partial
-    'idv/hardfail4'
-  end
-
   def requested_attributes
     sp_session[:requested_attributes].sort
   end
@@ -111,11 +107,11 @@ def sp_alert?
   end
 
   def sp_alert_name
-    sp_alert? ? SP_ALERTS[sp_name][:i18n_name] : nil
+    SP_ALERTS.dig(sp_name, :i18n_name)
   end
 
   def sp_alert_learn_more
-    sp_alert? ? SP_ALERTS[sp_name][:learn_more] : nil
+    SP_ALERTS.dig(sp_name, :learn_more)
   end
 
   private

app/decorators/session_decorator.rb

@@ -27,10 +27,6 @@ def verification_method_choice
     I18n.t('idv.messages.select_verification_without_sp')
   end
 
-  def idv_hardfail4_partial
-    'idv/no_sp_hardfail'
-  end
-
   def cancel_link_url
     view_context.root_url
   end