Skip to content

LG-322 Prompt PIV/CAC user to set up phone number#2244

Merged
monfresh merged 1 commit intomasterfrom
mb-piv-cac-require-backup-phone
Jun 15, 2018
Merged

LG-322 Prompt PIV/CAC user to set up phone number#2244
monfresh merged 1 commit intomasterfrom
mb-piv-cac-require-backup-phone

Conversation

@monfresh
Copy link
Contributor

@monfresh monfresh commented Jun 14, 2018

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

@monfresh monfresh requested a review from jgsmith-usds June 14, 2018 19:58
@monfresh
Copy link
Contributor Author

This PR allows PIV/CAC users to configure a backup phone number after setting up their PIV/CAC. It's missing a few more things that will come later today:

  • Allowing the user to skip setting up the backup phone number
  • Prompting the user to set up the phone number every time they sign in. Do we want to prompt before 2FA or after 2FA? In other words, do we want to prevent PIV/CAC users from signing in?

@monfresh
Copy link
Contributor Author

Here's a screenshot based on what @AvivaOskow posted in the issue:
screen shot 2018-06-14 at 3 57 24 pm

Copy link
Contributor

@jgsmith-usds jgsmith-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I haven't tried to support SAML since the SPs we're supporting don't use it, but adding the shared example at the bottom is a good step in that direction.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if we'd rather have this be a test of multiple 2fa options, but this should be good for now since we only get here through the piv/cac setup. Longer term, this may be a good hook to prompt someone to have multiple 2fa options configured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to keep it simple for now, and then expand later.

@monfresh monfresh force-pushed the mb-piv-cac-require-backup-phone branch 3 times, most recently from fc7cd4a to c7c989f Compare June 15, 2018 02:54
**Why**: PIV/CAC users are required to configure a backup phone number
so that they can sign in/recover their account if they no longer have
access to their PIV/CAC card.
@monfresh monfresh force-pushed the mb-piv-cac-require-backup-phone branch from c7c989f to 34a938e Compare June 15, 2018 03:24
@monfresh monfresh merged commit 5ccdfb6 into master Jun 15, 2018
@monfresh monfresh deleted the mb-piv-cac-require-backup-phone branch June 15, 2018 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants