Skip to content

Read encrypted_recovery_code_digest column#2229

Merged
jmhooper merged 1 commit intomasterfrom
jmhooper-write-personal-key-digest
Jun 27, 2018
Merged

Read encrypted_recovery_code_digest column#2229
jmhooper merged 1 commit intomasterfrom
jmhooper-write-personal-key-digest

Conversation

@jmhooper
Copy link
Contributor

Why: So that we can continue the migration to recovery code digests
that mirror password digests

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

@jmhooper
Copy link
Contributor Author

We should not merge this until #2220 is deployed

.reek Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring this here. This method will be deleted in the PR that stops reading from these columns

@jmhooper
Copy link
Contributor Author

Also, the base for this PR is jmhooper-verify-password for the purpose of showing the relevant changes. Once that branch is merged, this will need to be rebased and have its base changed to master.

@jmhooper jmhooper changed the base branch from jmhooper-verify-password to master June 14, 2018 01:54
@jmhooper jmhooper force-pushed the jmhooper-write-personal-key-digest branch from 25ec07e to f2ff6bc Compare June 14, 2018 01:55
@jmhooper
Copy link
Contributor Author

This has been rebased and I've changed the base. We'll still want to wait until after the next release before we merge.

**Why**: So that we can continue the migration to recovery code digests
that mirror password digests
@jmhooper jmhooper force-pushed the jmhooper-write-personal-key-digest branch from f2ff6bc to 4c17508 Compare June 22, 2018 17:44
@jmhooper
Copy link
Contributor Author

Okay, #2220 has been deployed and the recovery code digests have been backfilled. This one should be ready to go once it is reviewed.

Copy link
Contributor

@jgsmith-usds jgsmith-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper jmhooper merged commit 3365a6c into master Jun 27, 2018
@jmhooper jmhooper deleted the jmhooper-write-personal-key-digest branch February 15, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants