Skip to content

LG-351 Rate limiting does not work as expected in all cases of an email address#2222

Merged
stevegsa merged 1 commit intomasterfrom
stevegsa-fix-bypassing-rate-limit-on-login
Jun 6, 2018
Merged

LG-351 Rate limiting does not work as expected in all cases of an email address#2222
stevegsa merged 1 commit intomasterfrom
stevegsa-fix-bypassing-rate-limit-on-login

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jun 6, 2018

Why: We strip and downcase emails upon account creation but we do not do the same when passing emails to the rate limiter (rack attack).

How: Strip and downcase all emails before passing it to rack attack. Write a spec that tests for padding and mixed case.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

…il address

**Why**: We strip and downcase emails upon account creation but we do not do the same when passing emails to the rate limiter (rack attack).

**How**: Strip and downcase all emails before passing it to rack attack.  Write a spec that tests for padding and mixed case.
@stevegsa stevegsa requested a review from monfresh June 6, 2018 18:57
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevegsa stevegsa merged commit 181688f into master Jun 6, 2018
@amathews-fs amathews-fs deleted the stevegsa-fix-bypassing-rate-limit-on-login branch January 7, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants