LG-259 Password reset tokens should not leak to 3rd party sites (GA and NR)

[stevegsa]

Why: Password reset tokens on the url for the password reset page are leaked to third party sites google analytics and new relic.

How: After validating the token, implement redirection from the url with the token to the url without it while saving the token in session.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

• For DB changes, check for missing indexes, check to see if the changes
  affect other apps (such as the dashboard), make sure the DB columns in the
  various environments are properly populated, coordinate with devops, plan
  migrations in separate steps.

• For route changes, make sure GET requests don't change state or result in
  destructive behavior. GET requests should only result in information being
  read, not written.

• For encryption changes, make sure it is compatible with data that was
  encrypted with the old code.

• For secrets changes, make sure to update the S3 secrets bucket with the
  new configs in all environments.

• Do not disable Rubocop or Reek offenses unless you are absolutely sure
  they are false positives. If you're not sure how to fix the offense, please
  ask a teammate.

• When reading data, write tests for nil values, empty strings,
  and invalid formats.

• When calling redirect_to in a controller, use _url, not _path.

• When adding user data to the session, use the user_session helper
  instead of the session helper so the data does not persist beyond the user's
  session.

• When adding a new controller that requires the user to be fully
  authenticated, make sure to add before_action :confirm_two_factor_authenticated.

[davemcorwin]

I know the HackerOne ticket is only for password reset, but do we have this same issue for email confirmation and another other token-based auth?

[stevegsa]

The only other spot I know is on account creation which would seem to be less of a security concern because you haven't setup your account yet. The other token based urls seem to redirect properly (ie change email, etc.)