Merged
Conversation
**Why**: So we can create a readonly database user to be used in the console after #1996
Add rake task to create readonly database user
**Why**: So that console users in deployed environments will not be able to modify records without explicitly enabling write access. Enabling write access is done by setting ALLOW_CONSOLE_DB_WRITE_ACCESS=true. **How**: This commit adds a class called ProductionDatabaseConfiguration which is loaded in database.yml and used to determine the value of configs such as the username, password, and pool size. When the rails console is defined, it uses 2 new configs for user name and password that should correspond to a read only user.
Use readonly production database config in console
**Why**: Some email servers don't configure an MX record and rely on senders falling back to the A record, as recommended by the RFC. **How**: The email validation gem takes a parameter to do a check of the MX record and fall back to an A record if there is no MX record.
* Updated OTP and Session timeouts **Why**: In order to provide a bit more time for USAJobs users. * LG-132 Fixed tests **Why**: Changes to config broke a couple of them.
…g-mx LG-136 - Fall back to A record if MX record doesn't exist
**Why**: We need to steadily increase our sending volume when moving between AWS regions to keep from being block as spam. This commit allows us to configure what percentage of mail gets sent from what region.
**Why**: We want to be able to leverage several phone validation options, so we are (1) moving the validation to the backend, (2) giving feedback to the user when the phone number is considered valid, (3) enabling "Send Code" only when the phone number is considered valid. **How**: We send a POST to an endpoint when the phone input field blurs or the country code changes. The result of the POST indicates if the number is valid. We can add more information later.
LG-125 Select AWS SES region from a pool
…rs-before-sending-code LG-126 - Validate the appearance of phone numbers before allowing OTP submission
**Why**: To make sure that only requests that contain Twilio's signature are allowed. Reference: https://twilio-ruby.readthedocs.io/en/latest/usage/validation.html#rack-middleware
Validate Twilio requests to /api/voice/otp
**Why**: So they know up front when it will expire.
**Why**: Translations are not available for French and Spanish **How** Update the locale files
LG-123 Show OTP expiration to user on web page
jmhooper
approved these changes
Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.