Conversation
**Why**: Using the SameSite=Strict setting was breaking our app due to this Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=619603 Sessions were not properly being set and persisting, which was causing the SAML auth flow to end prematurely in production because we rely on the `session[:saml_request_url]` variable to continue the auth after the user signs in.
monfresh
added a commit
that referenced
this pull request
Mar 30, 2017
**Why**: - There is a bug in Chrome that causes the session to be reset in the following scenario: - Set cookies to use SameSite=Strict - Have Gmail open in a tab - In a different tab, visit sp.qa.login.gov and click Login.gov - Click "Get started" and enter your Gmail address - In the Gmail tab, click on the confirmation link in the email - In this new tab that was opened, complete the account setup Result: You are redirected to the profile instead of `sign_up/completed` We had originally set the setting to `Lax` due to this Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=619603 See #189 Because that bug was closed in July 2016, we thought that it was safe to go back to `Strict`, but it sounds like this might be a different bug, or perhaps that original one hasn't really been fixed. This bug only happens in Chrome, and seems to only happen when you click the confirmation link from Gmail. If you copy and paste the link in a new tab that you open manually, the redirect back to SP works fine. Similarly, if you click the link from a non-Gmail email website, it doesn't reset the session when it opens a new tab. I only tried fastmail.com though.
pkarman
pushed a commit
that referenced
this pull request
Mar 31, 2017
**Why**: - There is a bug in Chrome that causes the session to be reset in the following scenario: - Set cookies to use SameSite=Strict - Have Gmail open in a tab - In a different tab, visit sp.qa.login.gov and click Login.gov - Click "Get started" and enter your Gmail address - In the Gmail tab, click on the confirmation link in the email - In this new tab that was opened, complete the account setup Result: You are redirected to the profile instead of `sign_up/completed` We had originally set the setting to `Lax` due to this Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=619603 See #189 Because that bug was closed in July 2016, we thought that it was safe to go back to `Strict`, but it sounds like this might be a different bug, or perhaps that original one hasn't really been fixed. This bug only happens in Chrome, and seems to only happen when you click the confirmation link from Gmail. If you copy and paste the link in a new tab that you open manually, the redirect back to SP works fine. Similarly, if you click the link from a non-Gmail email website, it doesn't reset the session when it opens a new tab. I only tried fastmail.com though.
pkarman
pushed a commit
that referenced
this pull request
Mar 31, 2017
**Why**: - There is a bug in Chrome that causes the session to be reset in the following scenario: - Set cookies to use SameSite=Strict - Have Gmail open in a tab - In a different tab, visit sp.qa.login.gov and click Login.gov - Click "Get started" and enter your Gmail address - In the Gmail tab, click on the confirmation link in the email - In this new tab that was opened, complete the account setup Result: You are redirected to the profile instead of `sign_up/completed` We had originally set the setting to `Lax` due to this Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=619603 See #189 Because that bug was closed in July 2016, we thought that it was safe to go back to `Strict`, but it sounds like this might be a different bug, or perhaps that original one hasn't really been fixed. This bug only happens in Chrome, and seems to only happen when you click the confirmation link from Gmail. If you copy and paste the link in a new tab that you open manually, the redirect back to SP works fine. Similarly, if you click the link from a non-Gmail email website, it doesn't reset the session when it opens a new tab. I only tried fastmail.com though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Using the SameSite=Strict setting was breaking our app due to
this Chrome bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=619603
Sessions were not properly being set and persisting, which was causing
the SAML auth flow to end prematurely in production because we rely on
the
session[:saml_request_url]variable to continue the auth afterthe user signs in.