Skip to content

Stop reading old singular redirect_uri column #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Oct 18, 2017
Merged

Stop reading old singular redirect_uri column #1743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/models/service_provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,4 @@ def encryption_opts
def live?
active? && approved?
end

def redirect_uris
super.presence || Array(redirect_uri)
end
end
4 changes: 2 additions & 2 deletions spec/models/service_provider_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@
)
end

it 'is an array of the legacy redirect_uri' do
expect(service_provider.redirect_uris).to eq(%w[http://a.example.com])
it 'ignores the old singular column and just uses the new plural one' do
expect(service_provider.redirect_uris).to eq([])
end
end

Expand Down