Set up default SPs in each deployed environment#1686
Merged
zachmargolis merged 1 commit intomasterfrom Sep 21, 2017
Merged
Conversation
zachmargolis
commented
Sep 21, 2017
Gemfile
Outdated
Contributor
Author
There was a problem hiding this comment.
please review this PR so I can merge this to master first! 18F/identity-hostdata#1
brodygov
reviewed
Sep 21, 2017
Gemfile
Outdated
config/service_providers.yml
Outdated
Contributor
Author
There was a problem hiding this comment.
yikes -- yes good catch thx
Contributor
Author
There was a problem hiding this comment.
PTAL @ 7404d58b182de55189b639e6d04dfc48ab9c600d
config/service_providers.yml
Outdated
config/service_providers.yml
Outdated
zachmargolis
force-pushed
the
margolis-simplify-sp-registration
branch
from
7404d58 to
7f2a9ad
Compare
Contributor
Author
|
(doing to confirm that this works by deploying it to an environment before merging) |
Contributor
|
This explodes because we define a model class called |
brodygov
approved these changes
Sep 21, 2017
Contributor
brodygov
left a comment
brodygov
left a comment
There was a problem hiding this comment.
Looks good once tests and such pass
**Why**: Makes it easier to use the IDP and other apps
zachmargolis
force-pushed
the
margolis-simplify-sp-registration
branch
from
aea4672 to
6947c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Makes it easier to use the IDP and other apps