Allow running any Ruby 2.3 version, upgrade to latest.#1675
Merged
Conversation
Change the .ruby-version file to use `2.3` rather than `2.3.3`. This may require users to create an alias in their ruby version config to specify a particular point release. For example, in rbenv you would create a symlink from `2.3` to `2.3.5`. If you're using ruby-build and have rbenv-aliases installed, this will happen automatically when you install new versions of ruby. - https://github.com/tpope/rbenv-aliases Also update the version in the Dockerfile and CircleCI config to not pin to a specific point release. This has no impact on login.gov servers, which don't use the .ruby-version file. The Gemfile already allows any 2.3.* release after 2.3.3.
monfresh
approved these changes
Sep 18, 2017
Contributor
monfresh
left a comment
monfresh
left a comment
There was a problem hiding this comment.
LGTM. Is there a corresponding devops issue that ensures the latest 2.3 release will be installed?
Contributor
Author
|
Yes, we'll need to coordinate with https://github.com/18F/identity-devops/pull/618 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow running any ruby 2.3 version
Change the .ruby-version file to use
2.3rather than2.3.3. This mayrequire users to create an alias in their ruby version config to specify a
particular point release.
For example, in rbenv you would create a symlink from
2.3to2.3.5. Ifyou're using ruby-build and have rbenv-aliases installed, this will happen
automatically when you install new versions of ruby.
Also update the version in the Dockerfile and CircleCI config to not pin to a
specific point release.
This has no impact on login.gov servers, which don't use the .ruby-version
file. The Gemfile already allows any 2.3.* release after 2.3.3.
Enforce the use of ruby 2.3.5 or newer
https://www.ruby-lang.org/en/news/2017/08/29/multiple-vulnerabilities-in-rubygems/
https://github.com/18F/identity-devops-private/issues/502