Merged
Conversation
zachmargolis
force-pushed
the
margolis-host-headers
branch
2 times, most recently
from
c565a14 to
b43c871
Compare
**Why**: Malformed host headers cause exceptions
jmhooper
reviewed
Sep 14, 2017
| event.payload.except(:params, :headers) | ||
| end | ||
|
|
||
| config.middleware.insert_before 0, Rack::HeadersFilter |
Contributor
There was a problem hiding this comment.
It looks like the rack-header-filter gem let's you call this with a blacklist. Why not do that here?
Contributor
Author
There was a problem hiding this comment.
Oh thanks, I'd missed that gem entirely, will update
Contributor
Author
There was a problem hiding this comment.
Ok, so that gem deletes outgoing headers, not incoming headers, I don't think we can use it here
Contributor
Author
There was a problem hiding this comment.
Extremely frown town 😿
jmhooper
approved these changes
Sep 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Malformed host headers cause exceptions
--
I basically rewrote the middleware gem we added in #1663 because that gem only delete a particular 5 headers, not including
HTTP_HOSTso in order to delete that I had to get around itI would be open to removing the dependency entirely, but this seemed like an easier way to just re-use the list of headers we don't trust