Skip to content

Specify telephony service in specs #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monfresh merged 1 commit into from
Sep 11, 2017
Merged

Specify telephony service in specs #1669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spec/services/twilio_service_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
end

it 'sanitizes phone numbers embedded in error messages from Twilio' do
TwilioService.telephony_service = FakeVoiceCall
raw_message = 'Account not authorized to call +12345.'
error_code = '21211'
status_code = 400
Expand Down Expand Up @@ -138,6 +139,7 @@
end

it 'sanitizes phone numbers embedded in error messages from Twilio' do
TwilioService.telephony_service = FakeSms
raw_message = "The 'To' number +1 (888) 555-5555 is not a valid phone number"
error_code = '21211'
status_code = 400
Expand Down