Skip to content

Move _tag helpers into the template #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Aug 25, 2017
Merged

Move _tag helpers into the template #1642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions app/view_models/sign_up_completions_show.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
class SignUpCompletionsShow
include ActionView::Helpers::AssetTagHelper
include ActionView::Helpers::TagHelper

def initialize(loa3_requested:, decorated_session:)
Expand Down Expand Up @@ -36,10 +35,8 @@ def title
)
end

def image
image_tag(
helper.asset_url("user-signup-#{requested_loa}.svg"), width: 97, alt: '', class: 'mb2'
)
def image_name
"user-signup-#{requested_loa}.svg"
end

def requested_attributes_partial
Expand All @@ -61,8 +58,4 @@ def requested_attributes
def requested_loa
loa3_requested ? 'loa3' : 'loa1'
end

def helper
ActionController::Base.helpers
end
end
2 changes: 1 addition & 1 deletion app/views/sign_up/completions/show.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
.clearfix
.col-10.sm-col-8.mx-auto
.center
= @view_model.image
= image_tag(asset_url(@view_model.image_name), width: 97, alt: '', class: 'mb2')
h1.h3.mb3.my0.regular = @view_model.heading

p = t('help_text.requested_attributes.intro_html', app_name: APP_NAME,
Expand Down