Merged
Conversation
**Why**: Conflicts with current up-to-date information
zachmargolis
requested review from
JohnRahaghi,
brodygov,
jmhooper,
konklone,
monfresh and
mzia
konklone
reviewed
Aug 24, 2017
| @@ -1 +0,0 @@ | |||
| ssp_viewer:$apr1$/O6mfuN.$pct4cTe8r1j2B5RjM9mDZ1 | |||
Contributor
There was a problem hiding this comment.
Did this come from a private repo by mistake or something? Why were we keeping a basic auth username and (hashed) password in this repo to protect access to public contents?
Contributor
There was a problem hiding this comment.
This wasn't a mistake. It was there to build out the compliance masonry with gitpages and push out as a cloud.gov instance. I initially created with the hopes of using compliance masonry. These docs are super out of date and can be removed since we didn't go this route.
konklone
approved these changes
Aug 24, 2017
Contributor
konklone
left a comment
konklone
left a comment
There was a problem hiding this comment.
Looks good to me, though I left a question that would be worth answering anyway.
Contributor
Author
|
Thanks @mzia for confirming. Removing these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Conflicts with current up-to-date information
--
@konklone pointed out these are out of date for misleading
cc @mzia @JohnRahaghi is there any reason to keep these?