Remove cron dependency for worker health checker#1638
Merged
zachmargolis merged 1 commit intomasterfrom Aug 24, 2017
Merged
Conversation
Contributor
|
Does this mean we can't use cron jobs for anything? If so, will we need to rework everything in |
brodygov
approved these changes
Aug 24, 2017
Contributor
brodygov
left a comment
There was a problem hiding this comment.
Looks good to me. It would also be good to put some comments in the commit or in the code to explain that we now have the health check kick off the dummy job.
**Why**: cron (leader host) is not compatible with autoscaling groups Now, when our load balancer hits the worker health check endpoint (which it already does) we will enqueue dummy jobs so make sure we're healthy
78caaa3 to
a346500
Compare
Contributor
|
Right, in an auto scaling group all the instances are identical, so we don't have any way to ensure that cron jobs are only run on a single instance. I've seen a few different strategies to deal with this most commonly:
|
Contributor
Author
|
We're currently working on getting ahold of Sidekiq Enterprise to run our cronjobs for us for things like SFTPing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: cron (leader host) is not compatible with autoscaling groups