Translate HTML5 required input message#1636
Merged
Conversation
zachmargolis
approved these changes
Aug 24, 2017
Contributor
There was a problem hiding this comment.
s seems a little terse to me, what if we called it selector ?
Contributor
Author
There was a problem hiding this comment.
Renamed s to events
hursey013
force-pushed
the
bh-i18n-html5-required
branch
from
93b4920 to
1ad3e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides translated messages for HTML5 form validations. While implementing I noticed some elements of the existing logic was not working working as expected so I did some refactoring to make sure the form validation was being applied to all forms and fields on the page instead of just the first occurrence.