Remove style-guide dependency (again)#1632
Merged
Conversation
hursey013
force-pushed
the
bh-rethink-styles
branch
from
24139ea to
a7abd68
Compare
Contributor
|
Does anything need to be done to the JS? |
Contributor
Author
|
@gemfarmer negative, the npm package only includes fonts, favicons, and stylesheets at this point. |
hursey013
force-pushed
the
bh-rethink-styles
branch
from
a7abd68 to
571f3da
Compare
Contributor
|
@hursey013 it looks like this needs to be rebased to the point at which we shifted to Circle CI |
Contributor
|
It was already rebased. You can see the Circle CI is passing. The fact that Travis is not passing is a known issue because GitHub thinks it should call Travis. I will disable Travis completely now that my PR was merged. |
hursey013
force-pushed
the
bh-rethink-styles
branch
from
571f3da to
b633290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off... my apologies for the back and forth on this. After some discussion and great insight from @gemfarmer, I think my recent changes introduce too much complexity without enough benefit.
Rather than importing styles/assets from an external source, I think a more resilient approach may be to leave the assets coupled with the app and instead find a way to export the pieces needed for the style guide site on some sort of reoccurring basis.