Don't create Profile in ProfileMaker#new#1630
Merged
Conversation
zachmargolis
approved these changes
Aug 21, 2017
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM good catch! one small naming question, not a blocker
app/services/idv/profile_maker.rb
Outdated
Contributor
There was a problem hiding this comment.
what if we renamed this to save_profile -- since to me,make sounds more like a #new than a #save!?
Contributor
Author
There was a problem hiding this comment.
Agreed, will change
jmhooper
force-pushed
the
jmhooper-profile-maker-make-profile
branch
from
b1ebcb1 to
b44fccc
Compare
**Why**: So that a database write does not happen as the side-effect of a service class's initializer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that a database write does not happen as the side-effect of a service class's initializer.
This is something that has confused me several times while reading the code. I think this helps make things a bit more clear regarding when the profile record is actually created.
I'm also considering a change to make
ProfileMaker#make_profileintoMakeProfile#call.