Complete session in verify review controller#1623
Merged
Conversation
jmhooper
commented
Aug 17, 2017
|
|
||
| def profile | ||
| @_profile ||= Profile.find(profile_id) | ||
| @_profile ||= Profile.find_by(id: profile_id) |
Contributor
Author
There was a problem hiding this comment.
This fixes a bug that was found when re-organizing the confirmation controller specs. It looks like we expect this to return nil if there is no profile. That implies that profile_id is nil. Profile.find(nil) raises an error which the user sees as a 500.
monfresh
reviewed
Aug 18, 2017
| expect(pii.first_name.norm).to eq 'JOSE' | ||
| end | ||
|
|
||
| context 'user picked phone confrimation' do |
Contributor
There was a problem hiding this comment.
minor spelling error: s/confrimation/confirmation
**Why**: We were creating a profile in the verify/review#create method. That method redirects to verify/confirmations#show which then calls `#complete_session`. This means that the profile exists in quasi complete state between these requests. This commit makes a small change so the profile is created and completed in one step. Additionally, this commit cleans up the confirmations controller specs.
jmhooper
force-pushed
the
jmhooper-review-complete-session
branch
from
2f995fb to
b2633ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: We were creating a profile in the verify/review#create method.
That method redirects to verify/confirmations#show which then calls
#complete_session. This means that the profile exists in quasicomplete state between these requests. This commit makes a small change
so the profile is created and completed in one step. Additionally, this
commit cleans up the confirmations controller specs.