Skip to content

Remove redundant PII warning #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
Aug 15, 2017
Merged

Remove redundant PII warning #1612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .reek
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ UtilityFunction:
- WorkerHealthChecker::Middleware#call
- UserEncryptedAttributeOverrides#create_fingerprint
- LocaleHelper#locale_url_param
- Verify::Base#mock_vendor_partial
- IdvSession#timed_out_vendor_error
'app/controllers':
InstanceVariableAssumption:
Expand Down
8 changes: 0 additions & 8 deletions app/view_models/verify/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@ def initialize(error: nil, remaining_attempts:, idv_form:, timed_out: nil)

attr_reader :error, :remaining_attempts, :idv_form

def mock_vendor_partial
if FeatureManagement.no_pii_mode?
'verify/sessions/no_pii_warning'
else
'shared/null'
end
end

def title
I18n.t("idv.titles.#{step_name}")
end
Expand Down
1 change: 0 additions & 1 deletion app/views/verify/finance/new.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
- title @view_model.title
= render @view_model.mock_vendor_partial

h1.h3.my0 = @view_model.title
p.mt-tiny.mb0
Expand Down
1 change: 0 additions & 1 deletion app/views/verify/finance_other/new.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
- title @view_model.title
= render @view_model.mock_vendor_partial

h1.h3.my0 = @view_model.title
p.mt-tiny.mb0 = t('idv.messages.finance.intro_account')
Expand Down
1 change: 0 additions & 1 deletion app/views/verify/phone/new.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
- title @view_model.title
= render @view_model.mock_vendor_partial

h1.h2.my0 = t('idv.titles.session.phone')
p.mt-tiny.mb2 = t('idv.messages.phone.intro')
Expand Down
1 change: 0 additions & 1 deletion app/views/verify/sessions/_no_pii_warning.html.slim
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion app/views/verify/sessions/new.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
- title @view_model.title
= render @view_model.mock_vendor_partial

h1.h3.my0 = @view_model.title
= simple_form_for(@view_model.idv_form, url: verify_session_path,
Expand Down
22 changes: 0 additions & 22 deletions spec/view_models/verify/base_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,6 @@
require 'rails_helper'

RSpec.describe Verify::Base do
describe '#mock_vendor_partial' do
context 'idv vendor is mock' do
it 'returns no pii warning partial' do
allow(Figaro.env).to receive(:proofing_vendors).and_return('mock')

partial = Verify::Base.new(remaining_attempts: 1, idv_form: nil).mock_vendor_partial

expect(partial).to eq 'verify/sessions/no_pii_warning'
end
end

context 'idv vendor is not mock' do
it 'returns null partial' do
allow(Figaro.env).to receive(:proofing_vendors).and_return('other')

partial = Verify::Base.new(remaining_attempts: 1, idv_form: nil).mock_vendor_partial

expect(partial).to eq 'shared/null'
end
end
end

describe '#message' do
let(:timed_out) { false }
let(:view_model) do
Expand Down