Skip to content

Remove Rack::Attack #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Aug 24, 2017
Merged

Remove Rack::Attack #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ gem 'phonelib'
gem 'phony_rails'
gem 'premailer-rails'
gem 'proofer', github: '18F/identity-proofer-gem', branch: 'master'
gem 'rack-attack'
gem 'rack-cors', require: 'rack/cors'
gem 'readthis'
gem 'redis-session-store', github: '18F/redis-session-store', branch: 'master'
Expand Down
1 change: 0 additions & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,6 @@ DEPENDENCIES
premailer-rails
proofer!
pry-byebug
rack-attack
rack-cors
rack-mini-profiler
rack-test
Expand Down
2 changes: 0 additions & 2 deletions config/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class Application < Rails::Application
config.autoload_paths << Rails.root.join('app', 'mailers', 'concerns')
config.time_zone = 'UTC'

# config.middleware.use Rack::Attack unless Figaro.env.disable_email_sending == 'true'

config.browserify_rails.force = true
config.browserify_rails.commandline_options = '-t [ babelify --presets [ es2015 ] ]'
config.i18n.load_path += Dir[Rails.root.join('config', 'locales', '**', '*.{yml}')]
Expand Down
115 changes: 0 additions & 115 deletions config/initializers/rack_attack.rb
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion docs/SECURITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public key.

#### Network security

We rely on [fail2ban](http://www.fail2ban.org/wiki/index.php/Main_Page) within [Rack::Attack](https://github.com/kickstarter/rack-attack) to identify malicious requestors and ban appropriately. Rack::Attack enables throttling for prevention of DoS attacks and mitigates abusive requests, allowing us to rely less on short-term, one-off hacks to block a particular attack.

```
@jgrevich - relevant network security?
Expand Down
2 changes: 0 additions & 2 deletions spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@

config.before(:suite) do
Rails.application.load_seed
Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new
end

config.before(:each) do
Expand All @@ -44,7 +43,6 @@

config.before(:each) do
allow(ValidateEmail).to receive(:mx_valid?).and_return(true)
Rack::Attack.cache.store.clear
end

config.before(:each, twilio: true) do
Expand Down
Loading