Merged
Conversation
monfresh
reviewed
Jul 21, 2017
Contributor
There was a problem hiding this comment.
CC says this is not tested.
Contributor
Author
There was a problem hiding this comment.
whoops turns out the shared view_model helper method I defined was not included in this controller, fixed in 57b53cf
**Why**: Error type was used for button name also Also clean up repeated view_model methods
zachmargolis
force-pushed
the
margolis-missing-timeout-translations
branch
from
c7912db to
33e9b2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: error type was used for button name also
--
found this when checking on dev (where the timeout defaults to 0 so everything times out)