Conversation
hursey013
force-pushed
the
bh-i18n-dropdown
branch
from
221e786 to
e2f7211
Compare
Contributor
There was a problem hiding this comment.
-
Can we iterate over this with
I18n.available_locales-- so we get new locales added automatically? (maybe we can add a custom sort somewhere else, but would be good to minimize the number of places we have to update) -
Can we update these to only show the language selector if there is more than one thing in
I18n.available_locales? That way we have have the selector show up in lower envs while we QA our languages but then we don't show the selector in prod where we have other languages disabled temporarily
Contributor
There was a problem hiding this comment.
no need to use a ternary here! the > 1 is a true/false anyways 😬
hursey013
force-pushed
the
bh-i18n-dropdown
branch
3 times, most recently
from
5404d00 to
baf3def
Compare
zachmargolis
approved these changes
Jul 21, 2017
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! checked it out locally, works fine
hursey013
force-pushed
the
bh-i18n-dropdown
branch
from
baf3def to
64b2912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to manually switch to another language.
Desktop:
Mobile:
