Skip to content

Set up SMS OTP for translation #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Jul 5, 2017
Merged

Set up SMS OTP for translation #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/sms_otp_sender_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def otp_valid?(otp_created_at)
def send_otp(twilio_service, code, phone)
twilio_service.send_sms(
to: phone,
body: "#{code} is your #{APP_NAME} one-time security code."
body: I18n.t('jobs.sms_otp_sender_job.message', code: code, app: APP_NAME)
)
end
end
2 changes: 2 additions & 0 deletions config/locales/jobs/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ en:
message_repeat: >
Hello! Your login.gov one time security code is, %{code}, again, your
security code is, %{code}. Press 1 to repeat your code.
sms_otp_sender_job:
message: "%{code} is your %{app} one-time security code."
2 changes: 2 additions & 0 deletions config/locales/jobs/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ es:
voice_otp_sender_job:
message_final: NOT TRANSLATED YET
message_repeat: NOT TRANSLATED YET
sms_otp_sender_job:
message: NOT TRANSLATED YET
12 changes: 6 additions & 6 deletions config/locales/jobs/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
fr:
jobs:
voice_otp_sender_job:
message_final: 'Bonjour! Votre code de sécurité à utilisation unique de login.gov
message_final: >
Bonjour! Votre code de sécurité à utilisation unique de login.gov
est, %{code}, de nouveau, votre code de sécurité est, %{code}, au revoir!

'
message_repeat: 'Bonjour! Votre code de sécurité à utilisation unique de login.gov
message_repeat: >
Bonjour! Votre code de sécurité à utilisation unique de login.gov
est, %{code}, de nouveau, votre code de sécurité est, %{code}. Appuyez sur 1
pour répéter votre code.

'
sms_otp_sender_job:
message: NOT TRANSLATED YET
3 changes: 1 addition & 2 deletions spec/jobs/sms_otp_sender_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@

expect(msg.from).to match(/(\+19999999999|\+12222222222)/)
expect(msg.to).to eq('555-5555')
expect(msg.body).to include('one-time security code')
expect(msg.body).to include('1234')
expect(msg.body).to eq(I18n.t('jobs.sms_otp_sender_job.message', code: '1234', app: APP_NAME))
end

it 'does not send if the OTP code is expired' do
Expand Down