Set a default value for lockout period#1507
Merged
Conversation
monfresh
requested review from
el-mapache,
gemfarmer,
hursey013 and
zachmargolis
monfresh
force-pushed
the
mb-set-default-lockout-period
branch
from
89a9137 to
286c172
Compare
**Why**: Instead of having to rely on devops to deploy Figaro config changes before we can deploy code to our lower envs, we can make the `lockout_period_in_minutes` optional, and set a default value for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Instead of having to rely on devops to deploy Figaro config
changes before we can deploy code to our lower envs, we can make the
lockout_period_in_minutesoptional, and set a default value for it.