Use AccountReactivationSession object#1496
Merged
el-mapache merged 1 commit intomasterfrom Jun 27, 2017
Merged
Conversation
el-mapache
added
status - ready for review
and removed
status - work in progress
labels
monfresh
reviewed
Jun 26, 2017
Contributor
There was a problem hiding this comment.
Sorry for the delay in reviewing this. Looks good to me overall. Looks like we are not testing this line according to Code Climate.
Contributor
Author
There was a problem hiding this comment.
No worries, thanks for checking this out. I'll add the spec.
el-mapache
force-pushed
the
ab-reactivate-session
branch
from
a934955 to
e9d1a62
Compare
**Why**: To avoid hardcoding keys in the user session across multiple controllers, and to present an interface for managing account reactivation session data Spec to test confirm_personal_key before_action **Why**: CC reported that branch of logic as untested
el-mapache
force-pushed
the
ab-reactivate-session
branch
from
e9d1a62 to
a626410
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To avoid hardcoding keys in the user session across multiple
controllers, and to present an interface for managing account
reactivation session data