Conversation
Contributor
Author
|
I forgot to update the tests. Will push them shortly. |
app/services/idv/financials_step.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
Per the commit message: Remove extra analytics attributes for vendor reasons in the Financials and Phone steps because Equifax does not return any reasons for those verifications.
Contributor
Author
There was a problem hiding this comment.
monfresh
force-pushed
the
mb-vendor-validation
branch
from
712e98a to
a801603
Compare
**Why**: During UAT testing with Equifax, we came across some ID verification issues, some of which required changes to the equifax gem, and some of which required changes to the IdP code. **How**: - Remove extra analytics attributes for vendor reasons in the Financials and Phone steps because Equifax does not return any reasons for those verifications. - Update `vendor_params` so that all keys are Strings for consistency - Update equifax gem to latest commit on master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: During UAT testing with Equifax, we came across some ID
verification issues, some of which required changes to the equifax
gem, and some of which required changes to the IdP code.
How:
and Phone steps because Equifax does not return any reasons for those
verifications.
vendor_paramsso that all keys are Strings for consistency