Conversation
amoose
added
status - ready for review
status - work in progress
and removed
status - ready for review
labels
zachmargolis
reviewed
Jun 8, 2017
config/environments/test.rb
Outdated
Contributor
There was a problem hiding this comment.
Do we hit the line length limit if we use a ternary?
lib/user_flows_exporter.rb
Outdated
Contributor
There was a problem hiding this comment.
nit: capitalization. UserFlowExporter (lowercase 'L')
Contributor
|
We don't run this in CI because it's slow, right? Would it be a reasonable up if we stubbed out the "save_and_screenshot" part? That way we can make sure we don't break these accidentally? |
Contributor
Author
|
Yes, because they're slow and the additional burden on devs. I think that's a reasonable exploration. |
zachmargolis
approved these changes
Jun 8, 2017
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! verified locally that the flows generate stuff (didn't test the uploading)
Contributor
Author
|
Thanks for review, Zach. Rebasin' and mergin' 📯 |
Adds web export task (compatible with Federalist) Expands specs to cover new mail activation flow Relaxes style constraints for User Flows tool
amoose
force-pushed
the
amos-feature-user_flows_enhance
branch
from
68ea3a3 to
2aa930c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
How