Skip to content

Make sure gpg is installed#1478

Merged
zachmargolis merged 1 commit intomasterfrom
margolis-brew-install-gpg
Jun 12, 2017
Merged

Make sure gpg is installed#1478
zachmargolis merged 1 commit intomasterfrom
margolis-brew-install-gpg

Conversation

@zachmargolis
Copy link
Contributor

Why: We use gpg in the app now

@cryptofilegsa
Copy link

want to confirm that we are using pgp trust model and not trust on first use or classic trust models. (assuming here for a minute that GPG is being used to encrypt/decrypt emails)

@zachmargolis
Copy link
Contributor Author

@cryptofilegsa we are using GPG to encrypt files to SFTP to a vendor, we have a public key from them we've committed as a secret, so no trust-on-first use.

bin/setup Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Homebrew installation will only work on OS X, but this part of the script runs on Docker as well. How about we move this down below, under the part where the script exits if it's being run on Docker?

Also, if the Docker image doesn't come with gpg, we should update the Docker setup to install gpg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would want to gpg --dearmor and gpg --import the keys in docker case as well, how would that work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound like we'll need to duplicate those calls? That's the easiest and simplest way I can think of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok updated! verified that GPG was already included in our image

**Why**: We use gpg in the app now
@zachmargolis zachmargolis force-pushed the margolis-brew-install-gpg branch from 2d4c2ac to c3df25b Compare June 9, 2017 18:02
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmargolis zachmargolis merged commit 606695e into master Jun 12, 2017
@zachmargolis zachmargolis deleted the margolis-brew-install-gpg branch June 12, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants